docs(rfc): stovepipe record step design - #394
Open
mnoah1 wants to merge 1 commit into
Open
Conversation
mnoah1
marked this pull request as ready for review
July 16, 2026 19:33
| Following the extension rule "identity in, resolve internally," the Hooks contract takes a thin greenness identity rather than a controller-assembled external payload: | ||
|
|
||
| ``` | ||
| Notify(ctx, GreennessRef{Queue, URI, Project}) error |
Collaborator
There was a problem hiding this comment.
we may want to have this as a separate RFC for Hook and hooks could anything including notifications so we may want to name it agnostic of the function it serves
| (queue, uri, project) | ||
| ``` | ||
|
|
||
| `project` is empty for whole-repository greenness and is a stable project id in Phase 2. The key is derivable from identity the controller already holds, so storage requires no query by attribute or secondary index. |
Collaborator
There was a problem hiding this comment.
it records the status at the given commit? how do we answer the question of what is prev or next green commit for a given commit? how would that work? should that be a separate rfc?
| For a delivery carrying build id `B`: | ||
|
|
||
| ``` | ||
| 1. Load Build B. |
Collaborator
There was a problem hiding this comment.
why Build? why not the request? Shouldn't the buildsignal already capturing the status of request?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design proposal for the
recordstep outlined in stovepipe's workflow.md