Skip to content

Fix ticket map lookup key type mismatch and logging placeholder format #1421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Spagles wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −2
Open

Fix ticket map lookup key type mismatch and logging placeholder format #1421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e1b224
fix: pass sub-level UUID to allTickets map lookup on unload
Spagles Aug 1, 2026
b9ce594
fix: add missing placeholder to sub-level load error logger call
Spagles Aug 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/src/main/java/dev/ryanhcode/sable/api/sublevel/SubLevelTicketLoadingSystem.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public void onSubLevelRemoved(final SubLevel subLevel, final SubLevelRemovalReas
if (reason == SubLevelRemovalReason.UNLOADED) {
this.container.activeTickets.remove(serverSubLevel);

final SubLevelTicketInfo info = this.container.allTickets.get(serverSubLevel);
final SubLevelTicketInfo info = this.container.allTickets.get(serverSubLevel.getUniqueId());

if (info != null) {
info.setPointer(serverSubLevel.getLastSerializationPointer());
Expand Down
2 changes: 1 addition & 1 deletion .../src/main/java/dev/ryanhcode/sable/sublevel/storage/serialization/SubLevelSerializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ public static ServerSubLevel fullyLoad(final ServerLevel level, final SubLevelDa
try {
subLevel = (ServerSubLevel) plotContainer.allocateSubLevel(halfLoadedSubLevel.uuid(), plotX, plotZ, pose);
} catch (final IllegalArgumentException e) {
Sable.LOGGER.error("Failed to load sub-level, skipping", halfLoadedSubLevel, e);
Sable.LOGGER.error("Failed to load sub-level {}, skipping", halfLoadedSubLevel, e);
return null;
}

Expand Down