Skip to content

perf(fmt): avoid relative resolution in gitignore matching #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenjiahan merged 1 commit into from
Aug 5, 2026
+8 −1
Merged

perf(fmt): avoid relative resolution in gitignore matching #201

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/rstack/src/fmt/discoverPaths.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,12 +77,14 @@ const findGitRoot = async (cwd: string): Promise<string> => {

class GitIgnoreMatcher {
readonly #rootPath: string;
readonly #rootPrefix: string;
readonly #matchers = new Map<string, ReturnType<typeof ignore>>();
readonly #loads = new Map<string, Promise<void>>();
readonly #ignoredDirectories = new Map<string, boolean>();

private constructor(rootPath: string) {
this.#rootPath = rootPath;
this.#rootPrefix = rootPath.endsWith(path.sep) ? rootPath : `${rootPath}${path.sep}`;
}

static async create(cwd: string): Promise<GitIgnoreMatcher> {
Expand Down Expand Up @@ -120,7 +122,12 @@ class GitIgnoreMatcher {
return false;
}

const relativePath = path.relative(this.#rootPath, filePath);
const relativePath =
filePath === this.#rootPath
? ''
: filePath.startsWith(this.#rootPrefix)
? filePath.slice(this.#rootPrefix.length)
: path.relative(this.#rootPath, filePath);
if (relativePath === '' || !isRelativePathInside(relativePath)) {
return false;
}
Expand Down