Make assorted Libraries modules Flow strict-local (#57733) - #57733
Open
rubennorte wants to merge 8 commits into
Open
Make assorted Libraries modules Flow strict-local (#57733)#57733rubennorte wants to merge 8 commits into
rubennorte wants to merge 8 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@rubennorte has exported this pull request. If you are a Meta employee, you can view the originating Diff in D113763779. |
|
Warning JavaScript API change detected This PR commits an update to
This change was flagged as: |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 28, 2026
Summary: Pull Request resolved: react#57733 Upgrade several remaining Libraries modules (WebSocket, PanResponder, RCTEventEmitter, and Flow type tests) from `flow` to `flow strict-local` with accurate types. WebSocket exposes spec-mandated getters/setters and opts out of the `unsafe-getters-setters` lint with a scoped directive. Behavior is unchanged. Changelog: [Internal] Reviewed By: huntie Differential Revision: D113763779
meta-codesync
Bot
changed the title
rubennorte
force-pushed
the
export-D113763779
branch
from
July 28, 2026 17:25
b3f54d2 to
0768bf2
Compare
Summary: Upgrade the legacy native module spec files from `flow` to `flow strict-local` to enforce stricter local type checking. Loose `Object` types were replaced with the codegen-equivalent `UnsafeObject`, and `Array<any>` parameters with `Array<unknown>`, both of which are codegen-identical so the generated native interfaces are unchanged. Changelog: [Internal] Differential Revision: D113763785
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 29, 2026
Summary: Pull Request resolved: react#57733 Upgrade several remaining Libraries modules (WebSocket, PanResponder, RCTEventEmitter, and Flow type tests) from `flow` to `flow strict-local` with accurate types. WebSocket exposes spec-mandated getters/setters and opts out of the `unsafe-getters-setters` lint with a scoped directive. Behavior is unchanged. Changelog: [Internal] Reviewed By: huntie Differential Revision: D113763779
rubennorte
force-pushed
the
export-D113763779
branch
from
July 29, 2026 10:55
0768bf2 to
80f3623
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 29, 2026
Summary: Pull Request resolved: react#57733 Upgrade several remaining Libraries modules (WebSocket, PanResponder, RCTEventEmitter, and Flow type tests) from `flow` to `flow strict-local` with accurate types. WebSocket exposes spec-mandated getters/setters and opts out of the `unsafe-getters-setters` lint with a scoped directive. Behavior is unchanged. Changelog: [Internal] Reviewed By: huntie Differential Revision: D113763779
rubennorte
force-pushed
the
export-D113763779
branch
from
July 29, 2026 13:47
80f3623 to
023a4fa
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 29, 2026
Summary: Pull Request resolved: react#57733 Upgrade several remaining Libraries modules (WebSocket, PanResponder, RCTEventEmitter, and Flow type tests) from `flow` to `flow strict-local` with accurate types. WebSocket exposes spec-mandated getters/setters and opts out of the `unsafe-getters-setters` lint with a scoped directive. Behavior is unchanged. Changelog: [Internal] Reviewed By: huntie Differential Revision: D113763779
rubennorte
force-pushed
the
export-D113763779
branch
from
July 29, 2026 15:22
023a4fa to
eac27a4
Compare
Summary: Upgrade the Blob-related modules (`File`, `FileReader`, `URL`, `URLSearchParams`) from `flow` to `flow strict-local`. These expose spec-mandated getters/setters, so they opt out of the `unsafe-getters-setters` lint with a scoped `// flowlint unsafe-getters-setters:off` directive. `URL` also received small behavior-preserving refactors (local variables instead of parameter reassignment, explicit null/empty checks). Changelog: [Internal] Differential Revision: D113763778
Summary: Upgrade the StyleSheet modules from `flow` to `flow strict-local`. `processFilter` and `setNormalizedColorAlpha` required small, behavior-preserving refactors (local variables instead of reassigning function parameters, and explicit null/empty checks) to satisfy the stricter lints. Changelog: [Internal] Differential Revision: D113763790
Summary: Upgrade assorted Utilities modules from `flow` to `flow strict-local` with accurate types. `insetsDiffer` uses local variables instead of reassigning its function parameters. Behavior is unchanged. Changelog: [Internal] Differential Revision: D113763792
Summary: Upgrade assorted components from `flow` to `flow strict-local` with accurate types. `Button` replaces implicit truthiness checks with explicit comparisons that preserve the exact previous runtime behavior (no logic change). Changelog: [Internal] Differential Revision: D113763782
Summary: Upgrade `AppRegistry` (and its Flow type companion) and several Core timer modules from `flow` to `flow strict-local` with accurate types. Behavior is unchanged. Changelog: [Internal] Differential Revision: D113763781
Summary: Upgrade the element inspector dev support modules from `flow` to `flow strict-local`, replacing loose `Object`/`Function` types with the accurate types already used by their callers and dependencies. Changelog: [Internal] Differential Revision: D113763787
Summary: Pull Request resolved: react#57733 Upgrade several remaining Libraries modules (WebSocket, PanResponder, RCTEventEmitter, and Flow type tests) from `flow` to `flow strict-local` with accurate types. WebSocket exposes spec-mandated getters/setters and opts out of the `unsafe-getters-setters` lint with a scoped directive. Behavior is unchanged. Changelog: [Internal] Reviewed By: huntie Differential Revision: D113763779
rubennorte
force-pushed
the
export-D113763779
branch
from
July 29, 2026 16:47
eac27a4 to
4cfdd14
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Upgrade several remaining Libraries modules (WebSocket, PanResponder, RCTEventEmitter, and Flow type tests) from
flowtoflow strict-localwith accurate types. WebSocket exposes spec-mandated getters/setters and opts out of theunsafe-getters-setterslint with a scoped directive. Behavior is unchanged.Changelog: [Internal]
Reviewed By: huntie
Differential Revision: D113763779