Make Blob/File/URL modules Flow strict-local (#57728) - #57728
Open
rubennorte wants to merge 3 commits into
Open
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@rubennorte has exported this pull request. If you are a Meta employee, you can view the originating Diff in D113763778. |
|
Warning JavaScript API change detected This PR commits an update to
This change was flagged as: |
Summary: Upgrade the legacy native module spec files from `flow` to `flow strict-local` to enforce stricter local type checking. Loose `Object` types were replaced with the codegen-equivalent `UnsafeObject`, and `Array<any>` parameters with `Array<unknown>`, both of which are codegen-identical so the generated native interfaces are unchanged. Changelog: [Internal] Differential Revision: D113763785
Summary: Upgrade the Animated implementation and node modules from `flow` to `flow strict-local` to enforce stricter local type checking, replacing loose types with the accurate existing Animated type vocabulary. Behavior is unchanged. Changelog: [Internal] Differential Revision: D113763780
Summary: Pull Request resolved: react#57728 Upgrade the Blob-related modules (`File`, `FileReader`, `URL`, `URLSearchParams`) from `flow` to `flow strict-local`. These expose spec-mandated getters/setters, so they opt out of the `unsafe-getters-setters` lint with a scoped `// flowlint unsafe-getters-setters:off` directive. `URL` also received small behavior-preserving refactors (local variables instead of parameter reassignment, explicit null/empty checks). Changelog: [Internal] Reviewed By: huntie Differential Revision: D113763778
meta-codesync
Bot
changed the title
rubennorte
force-pushed
the
export-D113763778
branch
from
July 28, 2026 17:29
3403aad to
dce86bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Upgrade the Blob-related modules (
File,FileReader,URL,URLSearchParams) fromflowtoflow strict-local. These expose spec-mandated getters/setters, so they opt out of theunsafe-getters-setterslint with a scoped// flowlint unsafe-getters-setters:offdirective.URLalso received small behavior-preserving refactors (local variables instead of parameter reassignment, explicit null/empty checks).Changelog: [Internal]
Reviewed By: huntie
Differential Revision: D113763778