Skip to content

fix: sanitize shell/subprocess call in _osx_support.py #154654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
anupamme wants to merge 1 commit into from
Closed

fix: sanitize shell/subprocess call in _osx_support.py #154654

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions Lib/_osx_support.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,11 @@ def _read_output(commandstring, capture_stderr=False):
os.getpid(),), "w+b")

with contextlib.closing(fp) as fp:
if capture_stderr:
cmd = "%s >'%s' 2>&1" % (commandstring, fp.name)
else:
cmd = "%s 2>/dev/null >'%s'" % (commandstring, fp.name)
return fp.read().decode('utf-8').strip() if not os.system(cmd) else None
import subprocess
stderr = subprocess.STDOUT if capture_stderr else subprocess.DEVNULL
rc = subprocess.call(commandstring, shell=True, stdout=fp, stderr=stderr)
fp.seek(0)
return fp.read().decode('utf-8').strip() if not rc else None


def _find_build_tool(toolname):
Expand Down
Loading