Fix a format token returning literal instead of lowercase meridiem - #990
Closed
vedaant00 wants to merge 1 commit into
Closed
Fix a format token returning literal instead of lowercase meridiem#990vedaant00 wants to merge 1 commit into
a format token returning literal instead of lowercase meridiem#990vedaant00 wants to merge 1 commit into
Conversation
Author
|
Closing as a duplicate of #984, which predates this by a few weeks. Left a note there about also adding the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
DateTime.format("a")returns the literal string"a"instead of the lowercase am/pm marker:Why
The
atoken is declared in the formatter regex and in_LOCALIZABLE_TOKENS, but_format_localizable_tokenhas a branch forAand none fora, soafalls through toreturn token.Fix
abranch, mirroringAand lowercasing the localized day period (matching the existing_LOCALIZABLE_TOKENS["a"]lambda). Non-Latin locales likejaare unaffected since.lower()is a no-op there.test_am_pm_lowercase.arow to the format-token docs table.Full suite passes (1838 passed).
Pull Request Check List