fix(reports): do not report success when every model was skipped - #366
Open
Eljees wants to merge 1 commit into
Open
fix(reports): do not report success when every model was skipped#366Eljees wants to merge 1 commit into
Eljees wants to merge 1 commit into
Conversation
The console summary printed 'No issues found!' even when the scan skipped all files, which reads as a clean result. Signed-off-by: Eljees <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #218
When every model in the scan was skipped, the console report still printed the success line:
"No issues found" is only true of files that were actually scanned, and the skip notice sits below the
line most people stop reading at.
ConsoleReportnow distinguishes the two cases:The cheerful line stays exactly as it was when nothing was skipped, so a clean scan looks the same as before.
Exit codes are untouched — this PR only changes what the summary says.
Tests
tests/test_reports.py(new): with a skipped file the output must not contain "No issues found!" and mustmention the skipped count; with nothing skipped the original line must still appear.
AI-assisted (LLM used for drafting); the change and the test run are mine.