chore(CalendarMonth): Include OUIAProps for CalendarMonth - #12593
chore(CalendarMonth): Include OUIAProps for CalendarMonth#12593mshriver wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughCalendarMonth now accepts OUIA props, renders the corresponding ChangesCalendarMonth OUIA integration
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Add OUIA attribute support to CalendarMonth for better test automation. Co-authored-by: Cursor <[email protected]>
c23ff05 to
18d8c90
Compare
rebeccaalpert
left a comment
There was a problem hiding this comment.
Just a question about the snapshot test - any particular reason for it?
| expect(title).toBeVisible(); | ||
| }); | ||
|
|
||
| test('Matches snapshot', () => { |
There was a problem hiding this comment.
I'm just curious about the snapshot test - I think we've been trying to move away from them in PatternFly. Otherwise this looks great.
There was a problem hiding this comment.
happy to remove it, just following pattern for existing coverage including them.
Add OUIA attribute support to CalendarMonth for better test automation.
What:
Closes #12592
Summary by CodeRabbit
ouiaSafesafety flag (defaulting to enabled).