[COMMS-918] Make WP BaseContract correctly detect WPs with closed versions - #24409
Open
brunopagno wants to merge 2 commits into
Open
[COMMS-918] Make WP BaseContract correctly detect WPs with closed versions#24409brunopagno wants to merge 2 commits into
brunopagno wants to merge 2 commits into
Conversation
brunopagno
marked this pull request as ready for review
July 23, 2026 11:01
|
Caution The provided work package version does not match the core version Details:
Please make sure that:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/projects/FND/work_packages/COMMS-918/activity
What are you trying to accomplish?
A validation if the status of a work package can be updated checks if both version and status is closed. If so, it does not allow changing.
This behaviour needs to be updated to work with multiple versions. This PR addresses that by validating if any associated version is closed, then it does not allow changing the status.
Merge checklist