Fix 469 nginx notebook1 collision - #470
Open
aagbsn wants to merge 6 commits into
Open
Conversation
this avoids the collision of prometheus_node_exporter and nginx configuration for jupyter; we renamed notebook when ooni.nu was suspended and realized that this causes deployment problems because the ansible roles that deploy nginx configurations write the same hostname, causing only one site to be enabled.
Ansible Run Output 🤖Ansible Playbook Recap 🔍Ansible playbook output 📖
|
| Pusher | @aagbsn |
| Action | pull_request |
| Working Directory | |
| Workflow | .github/workflows/check_ansible.yml |
| Last updated | Wed, 29 Jul 2026 13:22:16 GMT |
to avoid needing two sets of host_vars for notebook.ooni.org and notebook1.htz-fsn.prod.ooni.nu, we use the canonical infrastructure domain for deployments and specify the additional ssl_domains to be maintained by dehydrated in the host_vars
This reverts commit 3850717. do not complicate things by adding multiple references to the same host
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this avoids collision of prometheus_node_exporter using the same name as jupyter and fixes a typo in the ssl_domains var that prevented the certificate from renewing.