url: align URLPatternInit with WebIDL - #64781
Open
Archkon wants to merge 2 commits into
Open
Conversation
Read URLPatternInit dictionary members in lexicographical order so getters and proxy traps observe the access sequence required by WebIDL. Signed-off-by: Archkon <[email protected]>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Archkon
marked this pull request as draft
July 27, 2026 14:28
Use sparse dictionary template values so URLPatternResult inputs only expose members present after WebIDL conversion. Emit present members in WebIDL order. Signed-off-by: Archkon <[email protected]>
Archkon
marked this pull request as ready for review
July 27, 2026 14:34
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #64781 +/- ##
==========================================
- Coverage 90.16% 90.15% -0.01%
==========================================
Files 744 744
Lines 242518 242509 -9
Branches 45692 45702 +10
==========================================
- Hits 218663 218643 -20
- Misses 15349 15387 +38
+ Partials 8506 8479 -27
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #64780