Bug 2048352 - Split the push workflow into VCS agnostic base classes - #3529
Open
nahadji wants to merge 2 commits into
Open
Bug 2048352 - Split the push workflow into VCS agnostic base classes#3529nahadji wants to merge 2 commits into
nahadji wants to merge 2 commits into
Conversation
Extract the version control agnostic parts of the mercurial push workflow into BaseRepository and BaseWorker (new vcs module): building and applying a stack of Phabricator patches, committing try_task_config.json, the skippable files detection, the push retry loop and the worker output handling. The Mercurial specific parts stay in MercurialRepository (renamed from Repository to avoid confusion with the upcoming Git implementation) and MercurialWorker: robustcheckout and batch clones, revision lookups with the Lando git2hg fallback, patch application through hg import, ssh push and the treestatus wait. No behavior change: this prepares the introduction of a Git implementation of the same workflow as subclasses of the new bases.
nahadji
marked this pull request as ready for review
July 28, 2026 12:43
La0
reviewed
Jul 29, 2026
La0
left a comment
La0
left a comment
Collaborator
There was a problem hiding this comment.
The Worker handle_build method could output a dedicated class instance in the future, so it's easier to process across various implementations (don't do it there, it's already a great base to build upon).
La0
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract the version control agnostic parts of the mercurial push workflow into BaseRepository and BaseWorker (new vcs module): building and applying a stack of Phabricator patches, committing try_task_config.json, the skippable files detection, the push retry loop and the worker output handling.
The Mercurial specific parts stay in MercurialRepository (renamed from Repository to avoid confusion with the upcoming Git implementation) and MercurialWorker: robustcheckout and batch clones, revision lookups with the Lando git2hg fallback, patch application through hg import, ssh push and the treestatus wait.
No behavior change: this prepares the introduction of a Git implementation of the same workflow as subclasses of the new bases (First step of the review feedback on #3490).