Fix an issue with formatting indented list items. - #1423
Merged
Conversation
The previous code used a regular expression to skip over the indentation preceding a list item marker (as in ` - `). However, the CommonMark API has a method for that, `ListItem.getMarkerIndent()`. By using that to determine the "real" start of the list item token, we avoid an issue where the value of that token (`- `) did not correspond to the text at the position we had recorded. PiperOrigin-RevId: 956195264
copybara-service
Bot
force-pushed
the
test_956156584
branch
from
July 30, 2026 01:21
5c2fc79 to
7d9649f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix an issue with formatting indented list items.
The previous code used a regular expression to skip over the indentation preceding a list item marker (as in
-). However, the CommonMark API has a method for that,ListItem.getMarkerIndent(). By using that to determine the "real" start of the list item token, we avoid an issue where the value of that token (-) did not correspond to the text at the position we had recorded.