fix: skip corrupted run state files in list_runs - #3814
Open
Quratulain-bilal wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Improves workflow run listing resilience by skipping unreadable or malformed state files.
Changes:
- Catches JSON parsing and file I/O errors in
list_runs(). - Skips affected workflow runs instead of aborting the listing.
Show a summary per file
| File | Description |
|---|---|
src/specify_cli/workflows/engine.py |
Adds error handling when loading run state files. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Medium
Comment on lines
+1586
to
+1590
| try: | ||
| with open(state_path, encoding="utf-8") as f: | ||
| state_data = json.load(f) | ||
| except (json.JSONDecodeError, OSError): | ||
| continue |
Comment on lines
+1589
to
+1590
| except (json.JSONDecodeError, OSError): | ||
| continue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrap json.load() in workflows/engine.py list_runs with ry/except (json.JSONDecodeError, OSError) so a single corrupted state.json doesn't crash the entire listing. Corrupted runs are silently skipped.