fix(extensions): guard the required manifest sections so one bad extension cannot break extension list

[jawwad-ali]

Problem

ExtensionManifest.REQUIRED_FIELDS only checks key presence:

for field in self.REQUIRED_FIELDS:      # schema_version, extension, requires, provides
    if field not in self.data:
        raise ValidationError(...)

So a section that is written but left empty (provides: → None, which is just how YAML spells an empty field) or given the wrong shape passes that check and then fails on first use:

extension: null  -> TypeError: argument of type 'NoneType' is not iterable
requires:  null  -> TypeError: argument of type 'NoneType' is not iterable
provides:  null  -> AttributeError: 'NoneType' object has no attribute 'get'
provides:  []    -> AttributeError: 'list' object has no attribute 'get'

Neither is a ValidationError, so both escape the callers that already handle malformed manifests. list_installed() catches ValidationError only and has a deliberate ⚠️ Corrupted extension fallback — so a single bad extension took down the entire command. Reproduced end-to-end with one broken and one good extension installed:

	specify extension list
before	exit 1, raw AttributeError, no output at all
after	exit 0 — the good extension is listed, the bad one shows as Corrupted extension

Fix

Add an isinstance guard for each required section. This mirrors the guards already in the same function for the nested optional keys —

if "commands" in provides and not isinstance(commands, list):
    raise ValidationError("Invalid provides.commands: expected a list")
if "hooks" in self.data and not isinstance(hooks, dict):
    raise ValidationError("Invalid hooks: expected a mapping")

— and _load_yaml's document-root check. Only the three required sections lacked one; they were the odd ones out.

Not a behaviour change for valid input

provides: {} is a well-shaped mapping, so the new check does not touch it:

• with hooks present → still validates (an extension may provide only hooks)
• with no hooks → still gets the pre-existing must provide at least one command or hook

Both are locked by regression tests. I got this wrong on the first attempt — my initial test asserted provides: {} must raise, which failed because the fixture defines hooks; the tests now assert the correct behaviour.

Verification

• test_required_section_not_mapping_rejected — 3 sections × 3 bad shapes (None, [], "text"): 9 fail before, all pass after.
• 2 regression guards for the provides: {} cases above.
• TestExtensionManifest: 55 passed.
• uvx [email protected] check src tests clean.

---

AI-assisted: authored with Claude Code. I reproduced the extension list exit-1 crash end-to-end (correct .registry layout, one broken + one good extension) and confirmed the graceful fallback now engages, rather than only testing the manifest in isolation.

[Copilot]

Pull request overview

Adds manifest section type validation so malformed extensions raise ValidationError and do not break extension listing.

Changes:

• Validate extension, requires, and provides as mappings.
• Add malformed-shape and empty-provides regression tests.

Show a summary per file

File	Description
src/specify_cli/extensions/__init__.py	Guards required manifest sections.
tests/test_extensions.py	Covers invalid shapes and valid empty mappings.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 2/2 changed files
• Comments generated: 0
• Review effort level: Medium

[mnriem]

Thank you!