Actions: Improve actions/cache-poisoning/poisonable-step and actions/untrusted-checkout/critical path UI - #22243
Open
JarLob wants to merge 4 commits into
Open
Conversation
…uffix for cache poisoning query
Start critical untrusted-checkout paths at the expression controlling the checkout, and share the provenance helpers with the cache-poisoning query.
Contributor
There was a problem hiding this comment.
Pull request overview
Improves alert provenance for two GitHub Actions security queries by highlighting the expression controlling an untrusted checkout.
Changes:
- Adds checkout-reference path edges and display labels.
- Updates query paths, messages, tests, and expected results.
- Adds a change note.
Show a summary per file
| File | Description |
|---|---|
actions/ql/lib/codeql/actions/security/UntrustedCheckoutQuery.qll |
Adds checkout-reference helpers. |
actions/ql/src/Security/CWE-829/UntrustedCheckoutCritical.ql |
Uses reference-based path origins. |
actions/ql/src/Security/CWE-349/CachePoisoningViaPoisonableStep.ql |
Links alerts to untrusted inputs. |
actions/ql/test/query-tests/Security/CWE-349/.github/workflows/cache_write_capable_workflow_dispatch.yml |
Adds a workflow fixture. |
actions/ql/test/query-tests/Security/CWE-829/UntrustedCheckoutCritical.expected |
Updates expected paths and alerts. |
actions/ql/test/query-tests/Security/CWE-349/CachePoisoningViaPoisonableStep.expected |
Updates expected paths and alerts. |
actions/ql/test/query-tests/Security/CWE-349/CachePoisoningViaDirectCache.expected |
Records fixture-related path edges. |
actions/ql/src/change-notes/2026-07-28-checkout-provenance.md |
Documents the UI improvement. |
Review details
- Files reviewed: 8/8 changed files
- Comments generated: 0
- Review effort level: Medium
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ) | ||
| ) | ||
| or | ||
| exists(string variable | isRunCheckoutReference(checkout, result, variable)) |
| or | ||
| checkout instanceof Run and | ||
| result = checkout and | ||
| not exists(Expression reference, string variable | |
| or | ||
| checkout instanceof Run and | ||
| result = checkout and | ||
| not exists(Expression reference, string variable | |
| path = source.(PRHeadCheckoutStep).getPath() | ||
| message = "due to privilege checkout of untrusted code from" and | ||
| path = source.(PRHeadCheckoutStep).getPath() and | ||
| untrustedInput = getCheckoutReference(source.(PRHeadCheckoutStep)) and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.