Skip to content

Restore dbgshim-only package layout - #5951

Merged
hoyosjs merged 1 commit into
mainfrom
juhoyosa/clean-dbgshim-package
Aug 5, 2026
Merged

Restore dbgshim-only package layout#5951
hoyosjs merged 1 commit into
mainfrom
juhoyosa/clean-dbgshim-package

Conversation

@hoyosjs

@hoyosjs hoyosjs commented Aug 5, 2026

Copy link
Copy Markdown
Member

Description

Return Microsoft.Diagnostics.DbgShim to its original dbgshim-only package layout by removing the universal cDAC and DBI assets. Diagnostic tools continue using the assets from the cDAC transport package.

Co-authored-by: Copilot App <[email protected]>

Copilot-Session: 71fbeb93-23f0-4387-af41-2301d4aadd81
Copilot AI review requested due to automatic review settings August 5, 2026 04:43
@hoyosjs
hoyosjs requested a review from a team as a code owner August 5, 2026 04:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR restores the Microsoft.Diagnostics.DbgShim NuGet package to a dbgshim-only layout by removing the previously packed universal cDAC (mscordaccore_universal) and DBI (mscordbi_universal) native assets, relying on diagnostic tools to obtain those assets from the cDAC transport package instead.

Changes:

  • Stop packing mscordaccore_universal into Microsoft.Diagnostics.DbgShim when PackageWithCDac is enabled.
  • Stop packing mscordbi_universal into Microsoft.Diagnostics.DbgShim when PackageWithCDac is enabled.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@hoyosjs

hoyosjs commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

/ba-g test unrelated to packaging logic.

@hoyosjs
hoyosjs enabled auto-merge (squash) August 5, 2026 06:04
@hoyosjs
hoyosjs merged commit 32306e7 into main Aug 5, 2026
24 of 26 checks passed
@hoyosjs
hoyosjs deleted the juhoyosa/clean-dbgshim-package branch August 5, 2026 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants