daemon: Document Unix socket setup on Windows - #25660
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
docker-agent
left a comment
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟡 NEEDS ATTENTION
docker-agent
left a comment
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🔴 CRITICAL
One high-severity factual error was found in the new Windows Unix socket section. The claim that --group accepts a comma-separated list of groups does not match established Docker Engine behavior, where --group is a single-value flag. This will mislead users who try to grant access to multiple groups.
The rest of the new section — the -H unix:// flag usage, the PowerShell code blocks, the user-profile path guidance — is well-written and follows the document's existing tone and format.
|
|
||
| Replace `<USER>` with your Windows user directory. Without `--group`, only | ||
| members of the Administrators group and the `SYSTEM` account can access the | ||
| socket. Use a comma-separated list to grant access to multiple users or groups. |
There was a problem hiding this comment.
[HIGH] --group does not accept a comma-separated list
The sentence "Use a comma-separated list to grant access to multiple users or groups" is inaccurate. The dockerd --group flag accepts a single group name — it does not support comma-separated values. Passing a comma-separated string would be treated as a literal group name (e.g., "docker-users,another-group") and would not grant access to multiple groups.
If Docker Engine 29.5 supports granting access to multiple groups on Windows, the correct syntax should be demonstrated explicitly (for example, by repeating the flag or using a different mechanism). Otherwise, this sentence should be removed or corrected to reflect that only a single group name is accepted.
There was a problem hiding this comment.
There was a problem hiding this comment.
You're absolutely right, I apologize for the incorrect finding. I missed that the Windows implementation specifically handles comma-separated values — the code at listeners_windows.go clearly splits the socketGroup by commas to support multiple groups and/or users.
The documentation is accurate as written. Thank you for the correction and the reference!
Show the Engine 29.5 opt-in listener and matching client endpoint. Explain group access and why the socket should use a user-profile path. Signed-off-by: Paweł Gronowski <[email protected]>
5852a53 to
cec93b8
Compare
docker-agent
left a comment
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟡 NEEDS ATTENTION
| --host tcp://192.168.59.3:2376 | ||
| ``` | ||
|
|
||
| #### Listen on a Unix socket on Windows |
There was a problem hiding this comment.
[MEDIUM] New section uses #### heading which is excluded from the table of contents
The document's toc_max defaults to 3 (h3), as no override is set in the front matter. The #### Listen on a Unix socket on Windows heading introduced by this PR is at level h4, so it won't appear in the rendered table of contents.
Consider using ### instead to give this section ToC visibility, or add toc_max: 4 to the front matter if nesting under ### Configuration using flags is intentional.
2 participants
Show the Engine 29.5 opt-in listener and matching client endpoint. Explain group access and why the socket should use a user-profile path.
Description
Related issues or tickets
Reviews