bundle: route config remote sync edits to source YAML - #6096
Draft
ilyakuz-db wants to merge 4 commits into
Draft
Conversation
Collaborator
Integration test reportCommit: 287afc4
8 interesting tests: 4 RECOVERED, 4 SKIP
Top 3 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
bundle config-remote-synccompares remote changes with the merged bundle configuration, then writes the original YAML files. When a resource is split across files or target overrides, merged list positions can point to the wrong YAML file or list item. Sync can also replace${var...}references with resolved values.Solution
Track where configuration values came from and route each edit back to the correct file, block, and list position. Handle keyed and positional lists, keep related rename and reference changes together, and preserve variable references when writing YAML.
Tests
Acceptance tests cover split keyed edits and renames, included files, positional list changes, and shifted variable references under both deployment engines. Unit tests cover routing and variable-restoration edge cases.
Limitation
If several source elements are indistinguishable, the current remote change data does not identify which one was edited.