refactor: merge deduplication tests into main InvitationManager spec - #2751
Merged
Conversation
Add all deduplication-related tests under a `describe "handling deduplication"` block in spec/services/invitation_manager_spec.rb, per review feedback on PR #2551 (discussion_r3055854926). Delete the separate invitation_manager_deduplication_spec.rb.
mroderick
marked this pull request as ready for review
July 28, 2026 14:02
KimberleyCook
approved these changes
Jul 28, 2026
olleolleolle
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves deduplication tests from their own file into
spec/services/invitation_manager_spec.rbunder adescribe "handling deduplication"block, per review feedback on PR #2551 (discussion_r3055854926).Deletes
spec/services/invitation_manager_deduplication_spec.rb.Why
The reviewer suggested consolidating deduplication tests into the main spec file for better ergonomics when flipping between test and implementation. Now that the service was extracted from
app/models/toapp/services/, this is a natural cleanup.Verification
39 examples, 0 failures: