Skip to content

chore: fix 14 trivial RuboCop cops - #2748

Merged
mroderick merged 16 commits into
masterfrom
fix-trivial-rubocop-cops
Jul 28, 2026
Merged

chore: fix 14 trivial RuboCop cops#2748
mroderick merged 16 commits into
masterfrom
fix-trivial-rubocop-cops

Conversation

@mroderick

Copy link
Copy Markdown
Collaborator

What

Fixes 14 RuboCop cops (safe autocorrect only), one commit per rule, then regenerates .rubocop_todo.yml.

Cops fixed

Cop Offenses Files
Lint/AmbiguousOperator 1 workshops_controller_spec.rb
Lint/RedundantStringCoercion 1 admin/sponsor_spec.rb
RSpec/BeEmpty 1 event_presenter_spec.rb
RSpec/ChangeByZero 3 admin/sponsors_controller_spec.rb
RSpec/ItBehavesLike 2 workshop_spec.rb
Rails/FilePath 1 admin/sponsors_controller_spec.rb
Style/CommentAnnotation 1 invitation_manager_spec.rb
Style/DefWithParentheses 4 email_header_helper.rb
Style/ExpandPathArguments 1 spec_helper.rb
Style/HashAsLastArrayItem 1 sponsor.rb
Style/Lambda 1 workshop_invitation.rb
Style/NegatedIf 2 setup.rake
Style/NumericLiteralPrefix 1 admin/workshops_spec.rb
Style/RedundantReturn 1 omniauth/codebar.rb
Style/RegexpLiteral 1 spec_helper.rb

15 cops total (2 in 1 shared commit where needed to pass pre-commit hook). RSpec/ImplicitSubject deliberately skipped — its autocorrect triggers RSpec/NamedSubject which is a bigger refactor.

22 offenses fixed across 15 files, all safe autocorrect.

@mroderick
mroderick marked this pull request as ready for review July 28, 2026 13:26
@mroderick
mroderick merged commit 1bf11af into master Jul 28, 2026
9 checks passed
@mroderick
mroderick deleted the fix-trivial-rubocop-cops branch July 28, 2026 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant