Skip to content

[CRE-1587] - Increase retry/timeout resilience for GCS chunk retrieval - #155

Merged
OpsBotPrime merged 2 commits into
masterfrom
alessandro_cre_1587_increase-retrytimeout-resilience-for-gcs-chunk-retrieval
Jul 30, 2026
Merged

[CRE-1587] - Increase retry/timeout resilience for GCS chunk retrieval#155
OpsBotPrime merged 2 commits into
masterfrom
alessandro_cre_1587_increase-retrytimeout-resilience-for-gcs-chunk-retrieval

Conversation

@gallone2000

Copy link
Copy Markdown
Contributor

Add ObjectStoreClient::new_with_retry to allow callers to override the transport-level retry configuration per backend (GCS and HTTP), re-export RetryConfig/BackoffConfig/Error so downstream crates don't need a direct object_store dependency, and fix a regression where HTTP backend options were silently discarded instead of being forwarded to HttpBuilder.

@gallone2000 gallone2000 self-assigned this Jul 27, 2026
@gallone2000
gallone2000 marked this pull request as ready for review July 27, 2026 14:15
@gallone2000
gallone2000 requested a review from ReinierMaas July 27, 2026 14:16
@gallone2000
gallone2000 force-pushed the alessandro_cre_1587_increase-retrytimeout-resilience-for-gcs-chunk-retrieval branch 3 times, most recently from 200cb4b to ee3068e Compare July 29, 2026 13:14

@ReinierMaas ReinierMaas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I have three small requests:

  • Ensure that the commit name is descriptive of the change.

Comment thread opsqueue/src/object_store/mod.rs Outdated
Comment thread opsqueue/src/object_store/mod.rs Outdated
@gallone2000
gallone2000 force-pushed the alessandro_cre_1587_increase-retrytimeout-resilience-for-gcs-chunk-retrieval branch 2 times, most recently from ea3a740 to da24671 Compare July 30, 2026 14:37
@gallone2000
gallone2000 force-pushed the alessandro_cre_1587_increase-retrytimeout-resilience-for-gcs-chunk-retrieval branch from da24671 to 6f339e6 Compare July 30, 2026 15:05
@gallone2000

Copy link
Copy Markdown
Contributor Author

@OpsBotPrime merge and tag

…unk retrieval

Approved-by: gallone2000
Priority: Normal
Auto-deploy: false
@OpsBotPrime

Copy link
Copy Markdown
Contributor

Rebased as 827996a, waiting for CI …

@OpsBotPrime

Copy link
Copy Markdown
Contributor

CI job 🟡 started.

@OpsBotPrime

Copy link
Copy Markdown
Contributor

@gallone2000 I tagged your PR with v59. Please wait for the build of 827996a to pass and don't forget to deploy it!

@OpsBotPrime
OpsBotPrime merged commit 827996a into master Jul 30, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants