Fix provider calendar source names on event cards - #2192
Open
martin-forge wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Agenda/list cards already use their metadata line for the source calendar: ICS events show the subscription name, while the calendar icon separately identifies the row as a calendar event.
Google and Microsoft events currently miss that source lookup and fall back to "Calendar" even when TaskNotes has the calendar name. This change resolves provider-owned events through
CalendarProviderRegistry, so that existing source field can show names such as Personal or Work.The calendar-event icon label, ICS subscription names, and translated fallback remain unchanged. Google's
primaryalias is mapped to the primary calendar metadata.Tests
npx jest tests/unit/issues/issue-provider-calendar-source-name.test.tsnpm run typechecknpx eslint src/ui/ICSCard.ts