perf: don't block onload on Bases registration - #2187
Open
tgrosinger wants to merge 1 commit into
Open
Conversation
registerBasesTaskList retried registration five times with 200ms sleeps when the Bases plugin had not finished loading, and onload awaited the whole thing. On mobile, where plugin load ordering is less predictable, that could stall plugin startup for a full second. registerBasesIntegration already owns retrying: it schedules a timer that re-attempts until the views are actually registered, checks the Bases plugin is enabled before each try, and is torn down on unload. So drop the inner loop entirely and make registerBasesTaskList a single attempt that reports its result, leaving one retry mechanism instead of two. onload no longer awaits it either.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
registerBasesTaskList retried registration five times with 200ms sleeps when the Bases plugin had not finished loading, and onload awaited the whole thing. On mobile, where plugin load ordering is less predictable, that could stall plugin startup for a full second.
registerBasesIntegration already owns retrying: it schedules a timer that re-attempts until the views are actually registered, checks the Bases plugin is enabled before each try, and is torn down on unload. So drop the inner loop entirely and make registerBasesTaskList a single attempt that reports its result, leaving one retry mechanism instead of two. onload no longer awaits it either.