Skip to content

feat(dataset): add dataset contributor display and editing - #6953

Open
xuang7 wants to merge 2 commits into
apache:mainfrom
xuang7:feat/dataset-contributor-frontend
Open

feat(dataset): add dataset contributor display and editing#6953
xuang7 wants to merge 2 commits into
apache:mainfrom
xuang7:feat/dataset-contributor-frontend

Conversation

@xuang7

@xuang7 xuang7 commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

What changes were proposed in this PR?

This PR adds the frontend support for dataset contributor metadata so that dataset authors and other contributors can be properly acknowledged.

Changes:

  • Adds a Contributorssection to the dataset detail page.
  • Displays contributors as cards.
  • Supports adding, editing, and removing contributors through a modal editor.
  • Restricts contributor updates to users with WRITE access.
  • Uses optimistic updates and rolls back changes if saving fails.
  • Adds an optional contributors form to the dataset creation flow.
  • Truncates long field values and displays the full content in tooltips.
  • Validates contributor email addresses.

Demo

Create a dataset with contributor metadata Add a contributor from the dataset detail page
Create a dataset with contributor metadata Add a contributor from the dataset detail page
 

Add a contributor and view long field values

add-contributor.mov

Remove a contributor

remove-contributor.mov

Any related issues, documentation, discussions?

Depends on #6952
Closes #6926

How was this PR tested?

Added frontend test cases for the contributor editor, dataset detail flows, service requests, and email validation. The flow was also manually tested in the UI.

Was this PR authored or co-authored using generative AI tooling?

Generated-by: Claude Code (Claude Fable 5)

@github-actions github-actions Bot added feature frontend Changes related to the frontend GUI labels Jul 27, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Automated Reviewer Suggestions

Based on the git blame history of the changed files, we recommend the following reviewers:

  • Contributors with relevant context: @rbelavadi, @aglinxinyuan, @mengw15
    You can notify them by mentioning @rbelavadi, @aglinxinyuan, @mengw15 in a comment.

Show a Contributors section on the dataset detail page with add/edit/delete
through a modal editor, and an optional contributors form when creating a
dataset. Requires the dataset contributor backend API.

Co-Authored-By: Claude Fable 5 <[email protected]>
@xuang7
xuang7 force-pushed the feat/dataset-contributor-frontend branch from 6f57f87 to 295c8a5 Compare July 28, 2026 21:25
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 69.44444% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.97%. Comparing base (bfe2b53) to head (2c2a3b3).

Files with missing lines Patch % Lines
...ser-dataset-explorer/dataset-detail.component.html 45.09% 27 Missing and 1 partial ⚠️
.../user-dataset-explorer/dataset-detail.component.ts 82.75% 2 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6953      +/-   ##
============================================
- Coverage     78.99%   78.97%   -0.03%     
  Complexity     3789     3789              
============================================
  Files          1160     1162       +2     
  Lines         46105    46213     +108     
  Branches       5115     5126      +11     
============================================
+ Hits          36420    36495      +75     
- Misses         8067     8096      +29     
- Partials       1618     1622       +4     
Flag Coverage Δ *Carryforward flag
access-control-service 70.00% <ø> (ø) Carriedforward from bfe2b53
agent-service 76.76% <ø> (ø) Carriedforward from bfe2b53
amber 72.21% <ø> (ø) Carriedforward from bfe2b53
computing-unit-managing-service 20.49% <ø> (ø) Carriedforward from bfe2b53
config-service 66.66% <ø> (ø) Carriedforward from bfe2b53
file-service 67.21% <ø> (ø) Carriedforward from bfe2b53
frontend 82.92% <69.44%> (-0.08%) ⬇️
notebook-migration-service 78.94% <ø> (ø) Carriedforward from bfe2b53
pyamber 95.38% <ø> (ø) Carriedforward from bfe2b53
workflow-compiling-service 26.31% <ø> (ø) Carriedforward from bfe2b53

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature frontend Changes related to the frontend GUI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support contributor metadata for datasets

2 participants