ci: drive website docs from release branches instead of pushing - #6948
ci: drive website docs from release branches instead of pushing#6948Ma77Ball wants to merge 1 commit into
Conversation
The old sync-docs-to-site.yml pushed docs/ into apache/incubator-texera-site on every main change. It has failed on every run: its SITE_SYNC_TOKEN identity has no write access to the site repo, which is why the published docs drifted. Switch to a pull model owned by the website: it pulls docs/ from the release branches at build time (see the companion site PR), so nothing is committed cross-repo and the site cannot drift. This repo's only job is to tell the site to rebuild when a release candidate is cut, via a repository_dispatch appended to create-release-candidate.yml. The site's daily schedule is the safety net. - Remove sync-docs-to-site.yml (broken push sync). - Add a notify-website job to create-release-candidate.yml. Co-Authored-By: Claude Opus 4.8 <[email protected]>
|
👋 Thanks for opening this pull request, @Ma77Ball! It looks like the pull request description doesn't quite follow our template yet:
Filling out the template helps reviewers understand and triage your contribution faster. Please edit the description to complete it. This message will disappear automatically once the template is followed. You can find the template prompts by editing the description, or see CONTRIBUTING.md for the full contribution flow. |
Automated Reviewer SuggestionsBased on the
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6948 +/- ##
============================================
+ Coverage 78.96% 78.99% +0.03%
+ Complexity 3798 3783 -15
============================================
Files 1161 1157 -4
Lines 46084 46061 -23
Branches 5110 5111 +1
============================================
Hits 36388 36388
+ Misses 8076 8057 -19
+ Partials 1620 1616 -4
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
| config | throughput | MB/s | latency | max Δ latest / 7d | |
|---|---|---|---|---|---|
| 🟢 | bs=10 sw=10 sl=64 | 378 | 0.231 | 25,449/34,981/34,981 us | 🟢 -8.7% / 🔴 +115.5% |
| 🔴 | bs=100 sw=10 sl=64 | 773 | 0.472 | 128,489/153,936/153,936 us | 🟢 -6.1% / 🔴 +41.7% |
| 🔴 | bs=1000 sw=10 sl=64 | 914 | 0.558 | 1,092,520/1,245,098/1,245,098 us | 🔴 +7.0% / 🔴 +18.9% |
Baseline details
Latest main 31f1e7b from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---|---|---|---|---|
| bs=10 sw=10 sl=64 | throughput | 378 tuples/sec | 385 tuples/sec | 767.9 tuples/sec | -1.8% | -50.8% |
| bs=10 sw=10 sl=64 | MB/s | 0.231 MB/s | 0.235 MB/s | 0.469 MB/s | -1.7% | -50.7% |
| bs=10 sw=10 sl=64 | p50 | 25,449 us | 25,893 us | 12,502 us | -1.7% | +103.6% |
| bs=10 sw=10 sl=64 | p95 | 34,981 us | 38,323 us | 16,234 us | -8.7% | +115.5% |
| bs=10 sw=10 sl=64 | p99 | 34,981 us | 38,323 us | 18,919 us | -8.7% | +84.9% |
| bs=100 sw=10 sl=64 | throughput | 773 tuples/sec | 795 tuples/sec | 974.8 tuples/sec | -2.8% | -20.7% |
| bs=100 sw=10 sl=64 | MB/s | 0.472 MB/s | 0.485 MB/s | 0.595 MB/s | -2.7% | -20.7% |
| bs=100 sw=10 sl=64 | p50 | 128,489 us | 121,693 us | 102,449 us | +5.6% | +25.4% |
| bs=100 sw=10 sl=64 | p95 | 153,936 us | 163,864 us | 108,652 us | -6.1% | +41.7% |
| bs=100 sw=10 sl=64 | p99 | 153,936 us | 163,864 us | 116,310 us | -6.1% | +32.3% |
| bs=1000 sw=10 sl=64 | throughput | 914 tuples/sec | 911 tuples/sec | 1,004 tuples/sec | +0.3% | -9.0% |
| bs=1000 sw=10 sl=64 | MB/s | 0.558 MB/s | 0.556 MB/s | 0.613 MB/s | +0.4% | -8.9% |
| bs=1000 sw=10 sl=64 | p50 | 1,092,520 us | 1,091,194 us | 999,606 us | +0.1% | +9.3% |
| bs=1000 sw=10 sl=64 | p95 | 1,245,098 us | 1,163,244 us | 1,046,770 us | +7.0% | +18.9% |
| bs=1000 sw=10 sl=64 | p99 | 1,245,098 us | 1,163,244 us | 1,076,937 us | +7.0% | +15.6% |
Raw CSV
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,529.32,200,128000,378,0.231,25449.39,34980.98,34980.98
1,100,10,64,20,2586.34,2000,1280000,773,0.472,128488.88,153935.66,153935.66
2,1000,10,64,20,21884.55,20000,12800000,914,0.558,1092520.22,1245097.87,1245097.87| run: | | ||
| gh api repos/apache/incubator-texera-site/dispatches \ | ||
| -f event_type=docs-updated \ | ||
| -f "client_payload[tag]=${{ github.event.inputs.tag }}" |
There was a problem hiding this comment.
how dose it pass the exact RC SHA?
What changes were proposed in this PR?
sync-docs-to-site.yml, the doc push-sync that 403s on every run because its token identity (aicam) has no write access toapache/incubator-texera-site.notify-websitejob tocreate-release-candidate.ymlthat fires arepository_dispatch(docs-updated) at the site repo after an RC uploads, so the site rebuilds from the release branches.AUTO_MERGE_TOKENand iscontinue-on-error; the site's daily schedule is the backstop if that PAT is not scoped for the site repo.Any related issues, documentation, discussions?
Closes: #6949
How was this PR tested?
python3 -c "import yaml; yaml.safe_load(open('.github/workflows/create-release-candidate.yml'))".create-release-candidate.yml, so it cannot be exercised in this PR; reviewers can confirm the wiring by reading thenotify-websitejob (event_type: docs-updatedmatches the site trigger in the companion PR).Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.8 in compliance with ASF