feat: add MongoDB driver handshake metadata for Java-based client connections - #39504
Open
alexbevi wants to merge 2 commits into
Open
feat: add MongoDB driver handshake metadata for Java-based client connections#39504alexbevi wants to merge 2 commits into
alexbevi wants to merge 2 commits into
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
alexbevi
force-pushed
the
add-client-metadata
branch
from
July 27, 2026 14:15
145ae9e to
3b5dd20
Compare
Contributor
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Signed-off-by: Alex Bevilacqua <[email protected]>
alexbevi
force-pushed
the
add-client-metadata
branch
from
July 27, 2026 15:55
3b5dd20 to
ac9bf8a
Compare
Resolves Gradle dependency analysis violation caused by using ConnectionString and MongoDriverInformation classes without explicitly declaring mongodb-driver-core as a dependency. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Contributor
|
Assigning reviewers: R: @chamikaramj for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passes
MongoDriverInformationtoMongoClients.create()inMongoDBResourceManagerso that MongoDB server-side telemetry can identify traffic originating from Apache Beam.What changes
it/mongodb/src/main/java/.../MongoDBResourceManager.javaDRIVER_INFOconstant (@VisibleForTesting) built withMongoDriverInformation.builder().driverName("Apache Beam").build().MongoClients.create(connectionString, DRIVER_INFO)when no externalMongoClientis provided. When a client is injected via the@VisibleForTestingconstructor (e.g. in unit tests), the external client is used unchanged.This will appear in mongos/d logs similar to:
See the MongoDB handshake specification for more info.