Rewrite: extra_rules_top takes priority over extra_permastructs on regex conflicts - #12774
Draft
SainathPoojary wants to merge 1 commit into
Draft
Rewrite: extra_rules_top takes priority over extra_permastructs on regex conflicts#12774SainathPoojary wants to merge 1 commit into
SainathPoojary wants to merge 1 commit into
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
There was a problem hiding this comment.
Pull request overview
This PR updates how WP_Rewrite::rewrite_rules() composes the final rewrite rules array so that rules in extra_rules_top take precedence over rules generated from extra_permastructs when they share the same regex key (per Trac #14991).
Changes:
- Collect extra permastruct-generated rules into a separate
$permastruct_rewritearray instead of merging them directly intoextra_rules_top. - Switch the final rewrite-rule composition to use PHP array union (
+) to prefer earlier keys on conflicts.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
1454
to
+1458
| // Put them together. | ||
| if ( $this->use_verbose_page_rules ) { | ||
| $this->rules = array_merge( $this->extra_rules_top, $robots_rewrite, $favicon_rewrite, $sitemap_rewrite, $deprecated_files, $registration_pages, $root_rewrite, $comments_rewrite, $search_rewrite, $author_rewrite, $date_rewrite, $page_rewrite, $post_rewrite, $this->extra_rules ); | ||
| $this->rules = $this->extra_rules_top + $permastruct_rewrite + $robots_rewrite + $favicon_rewrite + $sitemap_rewrite + $deprecated_files + $registration_pages + $root_rewrite + $comments_rewrite + $search_rewrite + $author_rewrite + $date_rewrite + $page_rewrite + $post_rewrite + $this->extra_rules; | ||
| } else { | ||
| $this->rules = array_merge( $this->extra_rules_top, $robots_rewrite, $favicon_rewrite, $sitemap_rewrite, $deprecated_files, $registration_pages, $root_rewrite, $comments_rewrite, $search_rewrite, $author_rewrite, $date_rewrite, $post_rewrite, $page_rewrite, $this->extra_rules ); | ||
| $this->rules = $this->extra_rules_top + $permastruct_rewrite + $robots_rewrite + $favicon_rewrite + $sitemap_rewrite + $deprecated_files + $registration_pages + $root_rewrite + $comments_rewrite + $search_rewrite + $author_rewrite + $date_rewrite + $post_rewrite + $page_rewrite + $this->extra_rules; |
| // Put them together. | ||
| if ( $this->use_verbose_page_rules ) { | ||
| $this->rules = array_merge( $this->extra_rules_top, $robots_rewrite, $favicon_rewrite, $sitemap_rewrite, $deprecated_files, $registration_pages, $root_rewrite, $comments_rewrite, $search_rewrite, $author_rewrite, $date_rewrite, $page_rewrite, $post_rewrite, $this->extra_rules ); | ||
| $this->rules = $this->extra_rules_top + $permastruct_rewrite + $robots_rewrite + $favicon_rewrite + $sitemap_rewrite + $deprecated_files + $registration_pages + $root_rewrite + $comments_rewrite + $search_rewrite + $author_rewrite + $date_rewrite + $page_rewrite + $post_rewrite + $this->extra_rules; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: #14991
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.