feat(gateway,cli): windows compilation support by araza008 · Pull Request #2496 · NVIDIA/OpenShell

araza008 · 2026-07-27T14:43:51Z

Summary

compile the OpenShell gateway and CLI natively on Windows MSVC for x86-64 and arm64. It is build support only. It does not add functional Windows support for MXC, the sandbox supervisor, or Windows services.

Related Issue

Changes

adds windows mise tasks
supports bundled-z3 with optional system z3
gates unix-only dependencies so the geteway and cli compile on windows
adds linting and pre-commit tasks

Testing

mise run --skip-tools windows:build:x64
mise run --skip-tools windows:build:arm64

Checklist

Follows Conventional Commits
Commits are signed off (DCO)
Architecture docs updated (if applicable)

copy-pr-bot · 2026-07-27T14:43:55Z

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

github-actions · 2026-07-27T14:44:02Z

All contributors have signed the DCO ✍️ ✅
_{Posted by the DCO Assistant Lite bot.}

araza008 · 2026-07-27T17:33:14Z

I have read the DCO document and I hereby sign the DCO.

jamieknvidia · 2026-07-27T23:12:18Z

I have read the DCO document and I hereby sign the DCO.

drew · 2026-07-28T05:03:59Z

/ok to test d0bcaca

gburachas · 2026-07-28T16:14:00Z

I have read the DCO document and I hereby sign the DCO.

Signed-off-by: Shailendra Singh <[email protected]> Signed-off-by: Akber Raza <[email protected]>

Signed-off-by: Akber Raza <[email protected]>

…ove build logic Signed-off-by: Akber Raza <[email protected]>

… with bundled Z3 features Signed-off-by: Akber Raza <[email protected]>

Signed-off-by: Giedrius Burachas <[email protected]> Signed-off-by: Akber Raza <[email protected]>

…re-specific subdirectories Signed-off-by: Akber Raza <[email protected]>

Signed-off-by: Akber Raza <[email protected]>

…ation and scripts Signed-off-by: Akber Raza <[email protected]>

Why: windows-msvc-build-design.mdx is a design document ("design decisions for the native Windows MSVC build lane"), but it lived in the published, user-facing docs/reference/ tree. Per AGENTS.md (Documentation) and architecture/README.md ("rfc/ vs architecture/"), design content belongs in architecture/ (or rfc/), not in published reference. It also shared Fern sidebar "position: 6" with the MXC compute-driver design page, colliding in the Reference nav ordering. What: - Move docs/reference/windows-msvc-build-design.mdx -> architecture/windows-msvc-build.md. - Strip the Fern publish frontmatter and add a plain H1, matching the other architecture docs. - Register it in the architecture doc index in architecture/README.md. - Repoint the inbound references (build-openshell-mxc-windows skill + reference, implement-openshell-mxc-driver skill) to the new path. With both design pages moved out of docs/reference/, the duplicate position-6 sidebar collision is resolved. Signed-off-by: Akber Raza <[email protected]>

…est exclusion list Signed-off-by: Akber Raza <[email protected]> # Conflicts: # tasks/scripts/windows-msvc.ps1

openshell-gateway-interceptors failed to compile on Windows (E0432: no UnixStream in tokio::net), breaking any Windows build of openshell-server (which depends on it unconditionally). The connect_unix_endpoint fn was already #[cfg(unix)]-gated, but the imports it uses (UnixStream, TokioIo, Uri, service_fn) were left ungated. Gate those four imports with #[cfg(unix)] too. No behavior change on unix; Windows now compiles (no errors, no unused-import warnings). Signed-off-by: Akber Raza <[email protected]>

Signed-off-by: Shailendra Singh <[email protected]> Signed-off-by: Akber Raza <[email protected]>

Signed-off-by: Akber Raza <[email protected]>

Signed-off-by: Shailendra Singh <[email protected]>

Signed-off-by: Akber Raza <[email protected]>

araza008 · 2026-07-29T16:04:08Z

/ok to test 15c622a

araza008 · 2026-07-29T16:55:59Z

/ok to test 7c96e78

drew · 2026-07-29T20:29:00Z

/ok to test 7c96e78

Signed-off-by: Akber Raza <[email protected]>

…nShell into windows_compilation

araza008 · 2026-07-29T21:47:34Z

/ok to test 923ecf0

araza008 · 2026-07-31T03:46:12Z

/ok to test c1d5e98

araza008 · 2026-07-31T05:08:32Z

/ok to test d1fa290

pimlock · 2026-07-31T22:32:02Z

/ok to test d1fa290

matthewgrossman · 2026-07-31T22:48:16Z

+From the OpenShell checkout root, use:
+
+```powershell
+git fetch gitlab main


should the gitlab references be converted into github? or make the skill origin-agnostic?

pimlock · 2026-08-01T00:36:10Z

One question came up while reviewing this - was having driver crates conditional in the server crate, rather than rely on stubs for each driver considered?

I did a quick spike here and I think this should work, but don't have a windows machine to check: araza008/OpenShell@windows_compilation...NVIDIA:OpenShell:spike/windows-exclude-unsupported-drivers

This way driver crates don't need any conditions, they are just excluded from the build process. There are some guard required in the server crate itself, but that seems a bit less intrusive than condition + a stub for all driver crates.

araza008 requested review from a team, derekwaynecarr, maxamillion and mrunalp as code owners July 27, 2026 14:43

drew changed the title ~~Windows compilation~~ feat(gateway,cli): windows compilation support Jul 28, 2026

shailendra-nv and others added 19 commits July 28, 2026 18:07

chore(windows): gate Unix-only workspace code for MSVC

d859284

Signed-off-by: Shailendra Singh <[email protected]> Signed-off-by: Akber Raza <[email protected]>

feat(windows): stub unsupported compute drivers

e4b7768

Signed-off-by: Shailendra Singh <[email protected]> Signed-off-by: Akber Raza <[email protected]>

ci(windows): add MSVC mise build lane

c78c1a0

Signed-off-by: Shailendra Singh <[email protected]> Signed-off-by: Akber Raza <[email protected]>

docs(windows): document MSVC build-only design

2e1fc1c

Signed-off-by: Shailendra Singh <[email protected]> Signed-off-by: Akber Raza <[email protected]>

docs(agent): add Windows MSVC build skill

80a9a11

Signed-off-by: Shailendra Singh <[email protected]> Signed-off-by: Akber Raza <[email protected]>

feat(windows): add Windows build support

f411ac2

Signed-off-by: Akber Raza <[email protected]>

refactor(windows): consolidate Windows-specific dependencies and impr…

e8a1226

…ove build logic Signed-off-by: Akber Raza <[email protected]>

feat(windows): add libclang path resolution and update cargo commands…

cd12c15

… with bundled Z3 features Signed-off-by: Akber Raza <[email protected]>

chore(tooling): lock Windows tool artifacts

7541fb4

Signed-off-by: Giedrius Burachas <[email protected]> Signed-off-by: Akber Raza <[email protected]>

feat(windows): enhance libclang path resolution to support architectu…

de33ded

…re-specific subdirectories Signed-off-by: Akber Raza <[email protected]>

Fix Windows dependency gating after sync merge

5baaa3f

Signed-off-by: Akber Raza <[email protected]>

fix(z3): update Z3 header path requirements in Windows build document…

3669d79

…ation and scripts Signed-off-by: Akber Raza <[email protected]>

remove openshell-supervisor-network from unsupported driver package t…

d95df2f

…est exclusion list Signed-off-by: Akber Raza <[email protected]> # Conflicts: # tasks/scripts/windows-msvc.ps1

feat(windows): add native ARM64 test support

7809c78

Signed-off-by: Shailendra Singh <[email protected]> Signed-off-by: Akber Raza <[email protected]>

fix(mise): skip Skaffold on Windows

7865116

Signed-off-by: Shailendra Singh <[email protected]> Signed-off-by: Akber Raza <[email protected]>

fix(windows): harden ARM64 toolchain discovery

a8e78bb

Signed-off-by: Shailendra Singh <[email protected]> Signed-off-by: Akber Raza <[email protected]>

fix(windows): scope ARM64 toolchain preflight

7ee6ebb

Signed-off-by: Shailendra Singh <[email protected]> Signed-off-by: Akber Raza <[email protected]>

shailendra-nv and others added 9 commits July 28, 2026 18:08

fix(windows): restore compatibility after GitHub sync

e5f5986

Signed-off-by: Shailendra Singh <[email protected]> Signed-off-by: Akber Raza <[email protected]>

fix(windows): avoid rate-limited Z3 source lookup

170bf6f

Signed-off-by: Shailendra Singh <[email protected]> Signed-off-by: Akber Raza <[email protected]>

fix(mise): skip Helm checks on Windows

dc4d03f

Signed-off-by: Shailendra Singh <[email protected]> Signed-off-by: Akber Raza <[email protected]>

fix(windows): support repository pre-commit checks

0677ab1

Signed-off-by: Shailendra Singh <[email protected]> Signed-off-by: Akber Raza <[email protected]>

fix(windows): stabilize native MSVC validation

7928f06

Signed-off-by: Akber Raza <[email protected]>

fix(windows): harden shared Z3 source cache

463e4ee

Signed-off-by: Shailendra Singh <[email protected]>

fix(windows): avoid leaking MSVC flags into clang-cl

20f3572

Signed-off-by: Akber Raza <[email protected]>

fix(windows): complete ARM64 migration audit

5856766

Signed-off-by: Akber Raza <[email protected]>

fix(windows): restore ARM64 Ninja discovery

6d0f148

Signed-off-by: Akber Raza <[email protected]>

araza008 force-pushed the windows_compilation branch from d0bcaca to 6d0f148 Compare July 29, 2026 14:56

refactor(windows): separate platform crate roots

15c622a

Signed-off-by: Akber Raza <[email protected]>

Merge branch 'main' into windows_compilation

7c96e78

araza008 added 2 commits July 29, 2026 16:15

fix(windows): restore proto include cfg gating

9e5da6c

Signed-off-by: Akber Raza <[email protected]>

Merge branch 'windows_compilation' of https://github.com/araza008/Ope…

923ecf0

…nShell into windows_compilation

refactor: address lint errors

c1d5e98

fix(windows): add preflight check for proxy auth file path

d1fa290

matthewgrossman reviewed Jul 31, 2026

View reviewed changes

Uh oh!

Conversation

araza008 commented Jul 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Related Issue

Changes

Testing

Checklist

Uh oh!

copy-pr-bot Bot commented Jul 27, 2026

Uh oh!

github-actions Bot commented Jul 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

araza008 commented Jul 27, 2026

Uh oh!

jamieknvidia commented Jul 27, 2026

Uh oh!

drew commented Jul 28, 2026

Uh oh!

gburachas commented Jul 28, 2026

Uh oh!

araza008 commented Jul 29, 2026

Uh oh!

araza008 commented Jul 29, 2026

Uh oh!

drew commented Jul 29, 2026

Uh oh!

araza008 commented Jul 29, 2026

Uh oh!

araza008 commented Jul 31, 2026

Uh oh!

araza008 commented Jul 31, 2026

Uh oh!

pimlock commented Jul 31, 2026

Uh oh!

matthewgrossman Jul 31, 2026

Choose a reason for hiding this comment

Uh oh!

pimlock commented Aug 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

araza008 commented Jul 27, 2026 •

edited

Loading

github-actions Bot commented Jul 27, 2026 •

edited

Loading