chore: add mobile visual testing skill - #79
Open
cryptotavares wants to merge 3 commits into
Open
Conversation
Mirror the metamask-mobile tooling changes (client-mcp-core 0.8.0) into the skill references so the docs match the shipped CLI: - Migrate MM_IOS_* error codes to the core ErrorCode set (MM_DEPENDENCIES_MISSING, MM_DEVICE_NOT_AVAILABLE, MM_INVALID_CONFIG) and note that the launch tool collapses unknown codes into MM_LAUNCH_FAILED. - Document the new launch flags --app-bundle and --metro-port, and add a Destructive Launch Flags section (--reinstall, --reset-app-data, --allow-fox-code-mismatch) with the --app-bundle / fox_code guardrails. - Prefer "yarn mm launch --metro-port <port>" over MM_METRO_PORT while keeping the env var documented as equivalent.
racitores
previously approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the
mobile-visual-testingskill underdomains/testing/skills/. The skill teaches AI agents how to drive MetaMask Mobile on an iOS Simulator through the project-localmmCLI for visual testing — launching the app, inspecting the current screen, tapping/typing, capturing screenshots, and debugging runtime state.This skill is the agent-facing companion to the tooling PR in the mobile repo: MetaMask/metamask-mobile#33858 (
feat: add visual test agent). That PR adds the actualmmCLI (built on@metamask/client-mcp-core+@metamask/device-mcp,idbbackend); this PR adds the skill that documents and standardizes how agents use it. The two should land together.What the skill covers
skill.md— the required workflow:yarn mm:doctor→launch→describe-screen→ interact (click/type/wait-for) → verify +screenshot→cleanup. Includes iOS targeting rules (--testidand a11y refs only), prod-only guardrails, and mobile gotchas.references/cli-reference.md— full command tables, syntax rules, targeting details, and the browser-only / e2e-only commands that are unavailable on mobile.references/error-recovery.md— error-code table (MM_*) and troubleshooting for launch, interaction, daemon, and Hermes failures.references/state-manipulation.md— reading/writing runtime state and calling controller methods viamm cdp(Hermes runtime).references/runtime-monitoring.md— capturing network requests and console logs via Hermes runtime interceptors.repos/metamask-mobile.md— repo-specific context for the skill.Type of Change
Skill Details (if adding a new skill)
Provider Name: MetaMask
Skill Name: mobile-visual-testing (domain: testing)
Brief Description: Drives MetaMask Mobile on an iOS Simulator via the
mmCLI (idb backend) for visual testing — verify UI changes, capture screenshots, test wallet flows, and debug app state. iOS-only, prod-only, reuses installed app/wallet state.Checklist
Testing
Exercised the skill end-to-end against a booted iOS Simulator with MetaMask installed:
yarn mm:doctor(toolchain PASS/FAIL report),yarn mm launch,describe-screen,click/typevia--testidand a11y refs,screenshot, andcleanup. Verified prod-only guardrails (--context e2erejected) and the documented error codes surface as described.Additional Context
Linked tooling PR (adds the
mmCLI itself): MetaMask/metamask-mobile#33858. This skill has no effect without that CLI present in the mobile repo, and vice versa the CLI is intended to be driven via this skill. In-repo reference for the tooling:tests/llm-workflow/README.md.