Restrict Pylint to just no-member, avoid duplicating Ruff - #16
Merged
Conversation
Pylint's astroid-based type inference is the only thing that catches attribute/method access that doesn't exist on a value's real type (no-member) - Ruff is purely AST-based and can't do this. Everything else Pylint could flag overlaps with Ruff and just adds noise plus runtime cost (measured ~30% faster on a small repo restricted to just this rule, since the inference machinery itself is the dominant cost either way). Co-Authored-By: Claude Sonnet 5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ruff is purely AST-based and can never catch attribute/method access that doesn't exist on a value's real type (Pylint's
no-member, E1101) — that requires astroid's type-inference machinery, which Pylint alone provides. Everything else Pylint could flag duplicates Ruff, so this scopes Pylint down to just the one check that matters and lets Ruff own the rest.Changes
pyproject.toml: replaced the long[tool.pylint.messages_control]disable list withdisable = ["all"]/enable = ["no-member"].github/instructions/python.instructions.md: clarified Pylint's role now that it's scoped to justno-memberMeasured on a small repo: restricting to just
no-membercut Pylint's runtime from 2.37s to 1.66s (~30% faster) — real but modest, since the type-inference machineryno-memberneeds is the dominant cost either way, not the number of enabled checkers.