-
Notifications
You must be signed in to change notification settings - Fork 15
task: opensource coverity #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jharlow-intel
wants to merge
2
commits into
master
Choose a base branch
from
task/coverity
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,126 @@ | ||
| name: Coverity Scan | ||
|
|
||
| # Public static analysis via the free Coverity Scan service (scan.coverity.com, | ||
| # operated by Black Duck). Coverity is a compiled-language analyzer: it must wrap | ||
| # the real C/C++ build with `cov-build`, so this workflow installs MKL, compiles | ||
| # the extension under capture, and uploads the result for analysis. | ||
| # | ||
| # One-time setup required before the first run (see the PR/commit notes): | ||
| # 1. Register IntelPython/mkl_random at https://scan.coverity.com/github | ||
| # (sign in with GitHub; the project name must match COVERITY_PROJECT below). | ||
| # 2. Add two repository secrets (Settings -> Secrets and variables -> Actions): | ||
| # COVERITY_SCAN_TOKEN - the project token from the Project Settings tab | ||
| # COVERITY_SCAN_EMAIL - a maintainer email for build notifications | ||
| # | ||
| # Free-tier quota for a project under 100K LOC (mkl_random is ~10K) is 28 | ||
| # builds/week, max 4/day, so this runs on a weekly schedule plus on demand | ||
| # rather than per-push. | ||
|
|
||
| on: | ||
| schedule: | ||
| - cron: "0 1 * * 1" # Mondays 01:00 UTC; well under the free build quota | ||
| workflow_dispatch: | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| concurrency: | ||
| group: coverity-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| env: | ||
| COVERITY_PROJECT: IntelPython/mkl_random | ||
|
|
||
| jobs: | ||
| coverity-scan: | ||
| # Forks lack the COVERITY_SCAN_* secrets; only run on the canonical repo. | ||
| if: github.repository == 'IntelPython/mkl_random' | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout repo | ||
| uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | ||
| with: | ||
| fetch-depth: 0 | ||
|
|
||
| - name: Setup Python | ||
| uses: actions/setup-python@5fda3b95a4ea91299a34e894583c3862153e4b97 # v7.0.0 | ||
| with: | ||
| python-version: "3.12" | ||
| architecture: x64 | ||
|
|
||
| - name: Install build dependencies | ||
| run: pip install cython "setuptools>=77" "numpy>=2" mkl-devel | ||
|
|
||
| - name: Export MKLROOT | ||
| run: | | ||
| # mkl-devel installs mkl.h + libmkl_rt into the Python prefix. | ||
| MKLROOT="$(python -c 'import sys; print(sys.prefix)')" | ||
| if [ ! -f "${MKLROOT}/include/mkl.h" ]; then | ||
| echo "::error::mkl.h not found under ${MKLROOT}; mkl-devel did not install as expected." | ||
| exit 1 | ||
| fi | ||
| # The wheel ships only the versioned libmkl_rt.so.3, not the bare | ||
| # linker name, so `g++ -lmkl_rt` fails until we add the symlink. | ||
| if [ ! -e "${MKLROOT}/lib/libmkl_rt.so" ]; then | ||
| rt_so=("${MKLROOT}/lib/"libmkl_rt.so.*) | ||
| if [ ! -e "${rt_so[0]}" ]; then | ||
| echo "::error::libmkl_rt.so.* not found under ${MKLROOT}/lib." | ||
| exit 1 | ||
| fi | ||
| ln -s "${rt_so[0]}" "${MKLROOT}/lib/libmkl_rt.so" | ||
| fi | ||
| echo "MKLROOT=${MKLROOT}" >> "$GITHUB_ENV" | ||
| echo "LD_LIBRARY_PATH=${MKLROOT}/lib:${LD_LIBRARY_PATH}" >> "$GITHUB_ENV" | ||
|
|
||
| - name: Download Coverity Build Tool | ||
|
jharlow-intel marked this conversation as resolved.
|
||
| env: | ||
| COVERITY_SCAN_TOKEN: ${{ secrets.COVERITY_SCAN_TOKEN }} | ||
| run: | | ||
| curl --location --no-progress-meter \ | ||
| --data-urlencode "token=${COVERITY_SCAN_TOKEN}" \ | ||
| --data-urlencode "project=${COVERITY_PROJECT}" \ | ||
| --output cov-analysis.tar.gz \ | ||
| https://scan.coverity.com/download/linux64 | ||
| # An invalid token/project returns a small HTML error page, not the | ||
| # multi-hundred-MB tarball. Fail loudly with a clear hint if so. | ||
| if [ "$(stat -c '%s' cov-analysis.tar.gz)" -lt 1000000 ]; then | ||
| echo "::error::Coverity build tool download failed. Verify the COVERITY_SCAN_TOKEN secret and that the registered project name matches '${COVERITY_PROJECT}'." | ||
| head -c 512 cov-analysis.tar.gz || true | ||
| exit 1 | ||
| fi | ||
| mkdir -p cov-analysis | ||
| tar -xzf cov-analysis.tar.gz --strip 1 -C cov-analysis | ||
| echo "${PWD}/cov-analysis/bin" >> "$GITHUB_PATH" | ||
|
|
||
| - name: Configure Coverity for GCC/G++ | ||
| run: cov-configure --gcc | ||
|
|
||
| - name: Build under cov-build | ||
| run: | | ||
| # Force a clean rebuild so g++ genuinely runs and Coverity can capture | ||
| # it. A stale .so or generated .cpp would skip compilation and yield | ||
| # "No files were emitted", which the upload rejects. | ||
| rm -rf build/ mkl_random/*.so mkl_random/mklrand.cpp | ||
| cov-build --dir cov-int pip install -e . --no-build-isolation --no-deps 2>&1 | tee cov-build.log | ||
| # The extension has 3 translation units (mklrand.cpp + the two src/*.cpp); | ||
| # bail out if none were captured. | ||
| if ! grep -qE "Emitted [1-9][0-9]* .*compilation unit" cov-build.log; then | ||
| echo "::error::Coverity captured 0 compilation units — the C++ build did not run under cov-build." | ||
| exit 1 | ||
| fi | ||
|
|
||
| - name: Submit results to Coverity Scan | ||
| env: | ||
| COVERITY_SCAN_TOKEN: ${{ secrets.COVERITY_SCAN_TOKEN }} | ||
| COVERITY_SCAN_EMAIL: ${{ secrets.COVERITY_SCAN_EMAIL }} | ||
| run: | | ||
| tar -czf cov-int.tgz cov-int | ||
| curl --no-progress-meter \ | ||
| --form token="${COVERITY_SCAN_TOKEN}" \ | ||
| --form email="${COVERITY_SCAN_EMAIL}" \ | ||
| --form [email protected] \ | ||
| --form version="${GITHUB_SHA}" \ | ||
| --form description="GitHub Actions ${GITHUB_REF_NAME} (run ${GITHUB_RUN_ID})" \ | ||
| --form project="${COVERITY_PROJECT}" \ | ||
| https://scan.coverity.com/builds | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.