Scheduler: remove _newAppointments flag and the unfinished appointments implementation - #34523
Open
aleksei-semikozov wants to merge 1 commit into
Open
Conversation
…ts implementation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the internal _newAppointments / newAppointments switch and deletes the corresponding unfinished “appointments_new” implementation, consolidating Scheduler behavior back onto the legacy AppointmentCollection pipeline.
Changes:
- Removed
_newAppointments-gated branching fromScheduler, workspace drag wiring, and tooltip strategies so only the legacy appointments flow remains. - Deleted the
appointments_new/**implementation (components, resizing helpers, utilities) and its associated Jest tests, plus the drag controller that only supported that path. - Moved/standardized shared date-text formatting usage onto
scheduler/utils/get_date_textand cleaned up “TODO” markers.
Reviewed changes
Copilot reviewed 46 out of 46 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme/js/__internal/scheduler/workspaces/work_space.ts | Removes newAppointments option usage and always attaches legacy drag events. |
| packages/devextreme/js/__internal/scheduler/utils/get_targeted_appointment.ts | Removes obsolete TODO header comment. |
| packages/devextreme/js/__internal/scheduler/utils/get_date_text.ts | Switches to Scheduler-local ViewType import and removes targeted-appointment helper no longer needed. |
| packages/devextreme/js/__internal/scheduler/tooltip_strategies/tooltip_strategy_base.ts | Removes new-appointments-only hooks and simplifies tooltip item click handling to legacy behavior. |
| packages/devextreme/js/__internal/scheduler/tooltip_strategies/desktop_tooltip_strategy.ts | Drops new-appointments-only initialization/guard logic; keeps legacy dragBehavior hook. |
| packages/devextreme/js/__internal/scheduler/scheduler.ts | Removes _newAppointments branching and deletes new-appointments drag/resize controller integration; always uses AppointmentCollection. |
| packages/devextreme/js/__internal/scheduler/m_subscribes.ts | Redirects date-text imports to common utils and removes old-impl TODO markers. |
| packages/devextreme/js/__internal/scheduler/m_compact_appointments_helper.ts | Removes obsolete TODO header comment. |
| packages/devextreme/js/__internal/scheduler/m_appointment_drag_behavior.ts | Removes obsolete TODO header comment. |
| packages/devextreme/js/__internal/scheduler/classes.ts | Removes obsolete TODO header comment. |
| packages/devextreme/js/__internal/scheduler/appointments_new/view_item.ts | Deleted (part of removed appointments_new implementation). |
| packages/devextreme/js/__internal/scheduler/appointments_new/view_item.test.ts | Deleted tests for removed appointments_new view item. |
| packages/devextreme/js/__internal/scheduler/appointments_new/utils/type_helpers.ts | Deleted (appointments_new-only utility). |
| packages/devextreme/js/__internal/scheduler/appointments_new/utils/get_view_model_diff.ts | Deleted (appointments_new-only diffing logic). |
| packages/devextreme/js/__internal/scheduler/appointments_new/utils/get_view_model_diff.test.ts | Deleted tests for removed diffing logic. |
| packages/devextreme/js/__internal/scheduler/appointments_new/utils/get_targeted_appointment.ts | Deleted (appointments_new-only targeted appointment builder). |
| packages/devextreme/js/__internal/scheduler/appointments_new/utils/get_targeted_appointment.test.ts | Deleted tests for removed targeted appointment helper. |
| packages/devextreme/js/__internal/scheduler/appointments_new/resizing/types.ts | Deleted (appointments_new-only resizing types). |
| packages/devextreme/js/__internal/scheduler/appointments_new/resizing/get_resized_dates.ts | Deleted (appointments_new-only resizing calculations). |
| packages/devextreme/js/__internal/scheduler/appointments_new/resizing/get_resized_dates.test.ts | Deleted tests for removed resizing calculations. |
| packages/devextreme/js/__internal/scheduler/appointments_new/resizing/get_resizable_config.ts | Deleted (appointments_new-only resizable config). |
| packages/devextreme/js/__internal/scheduler/appointments_new/resizing/get_resizable_config.test.ts | Deleted tests for removed resizable config. |
| packages/devextreme/js/__internal/scheduler/appointments_new/resizing/get_delta_time.ts | Deleted (appointments_new-only delta-time logic). |
| packages/devextreme/js/__internal/scheduler/appointments_new/resizing/get_delta_time.test.ts | Deleted tests for removed delta-time logic. |
| packages/devextreme/js/__internal/scheduler/appointments_new/resizing/get_appointment_date_range.ts | Deleted (appointments_new-only all-day resize range logic). |
| packages/devextreme/js/__internal/scheduler/appointments_new/resizing/get_appointment_date_range.test.ts | Deleted tests for removed date-range logic. |
| packages/devextreme/js/__internal/scheduler/appointments_new/const.ts | Deleted (appointments_new constants/styles). |
| packages/devextreme/js/__internal/scheduler/appointments_new/appointments.ts | Deleted (appointments_new component implementation). |
| packages/devextreme/js/__internal/scheduler/appointments_new/appointments.focus_controller.ts | Deleted (appointments_new focus controller). |
| packages/devextreme/js/__internal/scheduler/appointments_new/appointment/grid_appointment.ts | Deleted (appointments_new grid appointment view). |
| packages/devextreme/js/__internal/scheduler/appointments_new/appointment/grid_appointment.test.ts | Deleted tests for removed grid appointment view. |
| packages/devextreme/js/__internal/scheduler/appointments_new/appointment/base_appointment.ts | Deleted (appointments_new base appointment view). |
| packages/devextreme/js/__internal/scheduler/appointments_new/appointment/base_appointment.test.ts | Deleted tests for removed base appointment view. |
| packages/devextreme/js/__internal/scheduler/appointments_new/appointment/agenda_appointment.ts | Deleted (appointments_new agenda appointment view). |
| packages/devextreme/js/__internal/scheduler/appointments_new/appointment/agenda_appointment.test.ts | Deleted tests for removed agenda appointment view. |
| packages/devextreme/js/__internal/scheduler/appointments_new/appointment_collector.ts | Deleted (appointments_new collector component). |
| packages/devextreme/js/__internal/scheduler/appointments_new/appointment_collector.test.ts | Deleted tests for removed collector component. |
| packages/devextreme/js/__internal/scheduler/appointments_new/mock/base_appointment_view.ts | Deleted (appointments_new test mock). |
| packages/devextreme/js/__internal/scheduler/appointments_new/mock/appointment_view_model.ts | Deleted (appointments_new test mock). |
| packages/devextreme/js/__internal/scheduler/appointments_new/mock/appointment_collector.ts | Deleted (appointments_new test mock). |
| packages/devextreme/js/__internal/scheduler/appointment_drag_controller.ts | Deleted (controller only used by the removed appointments_new path). |
| packages/devextreme/js/__internal/scheduler/tests/appointments_resizing.test.ts | Deleted (tests specific to _newAppointments resizing). |
| packages/devextreme/js/__internal/scheduler/tests/appointments_new.test.ts | Deleted (tests specific to _newAppointments behavior). |
| packages/devextreme/eslint.config.mjs | Updates comment wording around underscore-member allowance in scheduler appointments folder. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.