Skip to content

[PWGUD] fix ptdiff - #17274

Merged
amatyja merged 1 commit into
AliceO2Group:masterfrom
miedema-11:master
Jul 31, 2026
Merged

[PWGUD] fix ptdiff#17274
amatyja merged 1 commit into
AliceO2Group:masterfrom
miedema-11:master

Conversation

@miedema-11

@miedema-11 miedema-11 commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

initialize the GFW objects for pT-diff vn correctly, otherwise it will crash

@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 6 disabled

@github-actions github-actions Bot changed the title fix ptdiff [PWGUD] fix ptdiff Jul 31, 2026
@alibuild

alibuild commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 1feb8c3 at 2026-07-31 11:30:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 33 errors and 28 warnings.'
Found 33 errors and 28 warnings.
++ [[ 33 -gt 0 ]]
++ cat /sw/BUILD/e0c59136207669e44f2f099659be59a462d64ce1/O2Physics-code-check/errors.txt
PWGUD/Tasks/flowCumulantsUpc.cxx:67:78: error: macro argument should be enclosed in parentheses [bugprone-macro-parentheses,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:69:8: error: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:245:22: error: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:256:5: error: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:512:59: error: redundant call to 'c_str' [readability-redundant-string-cstr,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:512:92: error: redundant call to 'c_str' [readability-redundant-string-cstr,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:515:59: error: redundant call to 'c_str' [readability-redundant-string-cstr,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:515:92: error: redundant call to 'c_str' [readability-redundant-string-cstr,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:532:12: error: variable 'dnx' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:532:17: error: variable 'val' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:554:5: error: redundant return statement at the end of a function with a void return type [readability-redundant-control-flow,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:559:12: error: variable 'dnx' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:559:17: error: variable 'val' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:581:5: error: redundant return statement at the end of a function with a void return type [readability-redundant-control-flow,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:589:40: error: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:597:40: error: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:643:29: error: the parameter 'track' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:794:22: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:800:26: error: implicit conversion 'unwrap_t<int>' (aka 'int') -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:804:20: error: implicit conversion 'unwrap_t<int>' (aka 'int') -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:808:24: error: implicit conversion 'unwrap_t<int>' (aka 'int') -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:812:20: error: implicit conversion 'unwrap_t<int>' (aka 'int') -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:827:34: error: use designated initializer list to initialize 'AcceptedTracks' [modernize-use-designated-initializers,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:858:11: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:898:9: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:899:11: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:900:14: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:900:38: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:902:18: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:905:18: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:909:11: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:948:5: error: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
PWGUD/Tasks/flowCumulantsUpc.cxx:958:11: error: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr,-warnings-as-errors]
++ [[ 28 -gt 0 ]]
++ cat /sw/BUILD/e0c59136207669e44f2f099659be59a462d64ce1/O2Physics-code-check/warnings.txt
PWGUD/Tasks/flowCumulantsUpc.cxx:263:51: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/flowCumulantsUpc.cxx:265:51: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/flowCumulantsUpc.cxx:267:51: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/flowCumulantsUpc.cxx:273:51: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/flowCumulantsUpc.cxx:280:51: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/flowCumulantsUpc.cxx:287:51: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/flowCumulantsUpc.cxx:303:51: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

@amatyja

amatyja commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Hi @miedema-11, Write some description, please!
Best regards
Adam

@miedema-11

Copy link
Copy Markdown
Contributor Author

Hi @miedema-11, Write some description, please! Best regards Adam

Hi Adam, I have added. Thank you

@amatyja
amatyja merged commit dcc8d10 into AliceO2Group:master Jul 31, 2026
15 of 16 checks passed
jokonig pushed a commit to jokonig/O2Physics that referenced this pull request Jul 31, 2026
@amatyja

amatyja commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Hi @miedema-11, after some conversation with Roman, it may happen that the HY train will be crashed due to large output. Could you introduce a switch which handle output messages, and output logs are stored only when flag is set to true?
Best regards
Adam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants