Skip to content

[PWGEM] Add option to separate EMCal and DCal cluster pairing for flow task - #17246

Open
mhemmer-cern wants to merge 1 commit into
AliceO2Group:masterfrom
mhemmer-cern:emcal-qc
Open

[PWGEM] Add option to separate EMCal and DCal cluster pairing for flow task#17246
mhemmer-cern wants to merge 1 commit into
AliceO2Group:masterfrom
mhemmer-cern:emcal-qc

Conversation

@mhemmer-cern

@mhemmer-cern mhemmer-cern commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator
  • Some additional cleanup of code-checker errors
  • Add omega and eta prime to the checkups of emcalPhotonMcTask.cxx if a cluster is coming from those particles on top of pi0 and eta.
  • Add column of vectors to EmEmcMcParticle table which stores the amplitude fraction that each EmMcParticle contributed to the total cluster energy
  • Add three new TruthClasses in emcalPhotonMcTask.cxx:
    • PhotonElectronBS
    • SplitPhotonCluster
    • SplitLeptonCluster
  • Add new function isFromBremsstrahlung to MCUtilities.h

@github-actions

github-actions Bot commented Jul 29, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 56 errors, ⚠️ 43 warnings, 🔕 12 disabled

@mhemmer-cern
mhemmer-cern enabled auto-merge (squash) July 29, 2026 09:37
alibuild
alibuild previously approved these changes Jul 29, 2026

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @mhemmer-cern.

@vkucera vkucera changed the title [PWGEM] Add option to separate EMCal and DCal cluster pairing for flo… [PWGEM] Add option to separate EMCal and DCal cluster pairing for flow task Jul 29, 2026
@vkucera
vkucera disabled auto-merge July 29, 2026 15:22
@AliceO2Group AliceO2Group deleted a comment from alibuild Jul 30, 2026
@mhemmer-cern
mhemmer-cern marked this pull request as draft July 30, 2026 21:11
…w task

[PWGEM] PM: Add amplitude of McParticles to derived data

- Add column of vectors to EmEmcMcParticle table which stores the amplitude fraction that each EmMcParticle contributed to the total cluster energy
- Add three new TruthClasses in `emcalPhotonMcTask.cxx`:
  - PhotonElectronBS
  - SplitPhotonCluster
  - SplitLeptonCluster
- Add new function `isFromBremsstrahlung` to `MCUtilities.h`
@AliceO2Group AliceO2Group deleted a comment from alibuild Jul 31, 2026
@mhemmer-cern
mhemmer-cern marked this pull request as ready for review July 31, 2026 05:16
@mhemmer-cern
mhemmer-cern enabled auto-merge (squash) July 31, 2026 05:16

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @mhemmer-cern.

@mhemmer-cern
mhemmer-cern disabled auto-merge July 31, 2026 05:17
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 7ba00fa at 2026-07-31 07:56:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 1 errors and 0 warnings.'
Found 1 errors and 0 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/4458dae42e4ce4dc36fd3f61471cb24db41b9ba2/O2Physics-code-check/errors.txt
PWGEM/PhotonMeson/TableProducer/associateMCinfoPhoton.cxx:120:27: error: no header providing "std::array" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 1 -gt 0 ]]
++ exit 1
--

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

datamodel photon Photon and neutral meson PAG label pwgem

Development

Successfully merging this pull request may close these issues.

2 participants