Skip to content

fix(LoginForm): Adjust wrapper for submit button - #12605

Merged
rebeccaalpert merged 1 commit into
patternfly:mainfrom
rebeccaalpert:action-group
Jul 29, 2026
Merged

fix(LoginForm): Adjust wrapper for submit button#12605
rebeccaalpert merged 1 commit into
patternfly:mainfrom
rebeccaalpert:action-group

Conversation

@rebeccaalpert

@rebeccaalpert rebeccaalpert commented Jul 29, 2026

Copy link
Copy Markdown
Member

What: Part of patternfly/patternfly#8486

Additional issues:

Summary by CodeRabbit

  • Style
    • Improved the layout and grouping of the primary “Log In” button within the login form.
    • Preserved the button’s existing label, appearance, submission behavior, and disabled state.

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 10c6f96b-655e-492d-b0cc-fed750af118b

📥 Commits

Reviewing files that changed from the base of the PR and between 2c68c9a and d05dbad.

⛔ Files ignored due to path filters (1)
  • packages/react-core/src/components/LoginPage/__tests__/__snapshots__/LoginForm.test.tsx.snap is excluded by !**/*.snap
📒 Files selected for processing (1)
  • packages/react-core/src/components/LoginPage/LoginForm.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/react-core/src/components/LoginPage/LoginForm.tsx

Walkthrough

The login submit button is now wrapped in a FormGroup configured as an action group. Its existing behavior, props, and displayed label remain unchanged.

Changes

Login form layout

Layer / File(s) Summary
Wrap login submit control
packages/react-core/src/components/LoginPage/LoginForm.tsx
The “Log In” button is enclosed in an action FormGroup while retaining its existing submission behavior and label.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: mcoker

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is concise and accurately reflects the LoginForm wrapper change around the submit button.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Fix failing CI checks
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@rebeccaalpert
rebeccaalpert marked this pull request as ready for review July 29, 2026 17:44
@rebeccaalpert
rebeccaalpert requested a review from mcoker July 29, 2026 17:44

@mcoker mcoker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐️

@rebeccaalpert
rebeccaalpert merged commit 5822e05 into patternfly:main Jul 29, 2026
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants