feat: resolve swap quote metadata by migration phase - #9744
Open
micaelae wants to merge 81 commits into
Open
Conversation
This reverts commit aa5c5d2.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8f7edf3. Configure here.
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Explanation
Draft client PRs
References
Checklist
Note
Medium Risk
Breaking selector and submit APIs can mis-display fees and amounts if clients pass the wrong phase; changes sit on the bridge/swap quote path but are gated by explicit migration phases.
Overview
Introduces a breaking
migrationPhase('1' | '1.5' | '2') so bridge quote metadata can move from client-sidecalcQuoteMetadatato API-backed V2 fields in a controlled rollout.bridge-controller: Callers must pass
migrationPhaseinto quote selectors (selectBridgeQuotes,selectBatchSellQuotes). The selector pipeline addscalcQuoteMetadataV2(fiat from quote USD + native USD→fiat rate) and merges viamergeQuoteMetadataby phase: 1 = legacy only; 1.5 = API/fiat metadata with legacy fallback (and legacy top-level fields for client testing); 2 = normalized amounts + API-derived fiat only.toQuoteMetadataV1is updated to respect the phase when reading V2 quotes.bridge-status-controller:
submitTxacceptsmigrationPhase(default'1');submitIntentandsubmitBatchSellrequire it on their params objects. V2 quotes are converted to V1 for internal submission using the same phase-aware merge/metadata extraction.Reviewed by Cursor Bugbot for commit 0e01525. Bugbot is set up for automated code reviews on this repo. Configure here.